lars/giant
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix LaTeX-unavailable skip check in analyze metrics smoke test
CI / Lint (ruff check) (push) Successful in 27s
Details
CI / Format (ruff format) (push) Successful in 43s
Details
CI / Sync project version with tag (push) Has been skipped
Details
CI / Type check (ty) (push) Successful in 37s
Details
CI / Lint (ruff check) (pull_request) Successful in 29s
Details
CI / Format (ruff format) (pull_request) Successful in 28s
Details
CI / Sync project version with tag (pull_request) Has been skipped
Details
CI / Type check (ty) (pull_request) Successful in 43s
Details
CI / Tests (push) Successful in 6m14s
Details
CI / Tests (pull_request) Successful in 4m25s
Details
CI / Bump version, tag, and update changelog on merge to master (push) Has been skipped
Details
CI / Bump version, tag, and update changelog on merge to master (pull_request) Has been skipped
Details

Browse Source 
CliRunner stores an uncaught exception in result.exception, not
result.output, so the skip condition never matched and the test
failed outright on CI machines without LaTeX installed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Lars Bogner
2026-08-24 11:15:51 +02:00
parent bdebd83c8b
commit 7560e2bff0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_training_plots.py
+2 -2
View File
@@ -327,7 +327,7 @@ def test_cli_analyze_metrics_smoke(tmp_path: Path):
runner = CliRunner()
result = runner.invoke(app, ["analyze", "metrics", str(run_dir), "--out", str(out_dir)])
if result.exit_code != 0 and "LaTeX" in str(result.output):
if result.exit_code != 0 and "latex" in (str(result.output) + str(result.exception)).lower():
pytest.skip("LaTeX rendering unavailable")
assert result.exit_code == 0, result.output
assert result.exit_code == 0, result.output or result.exception
assert any(out_dir.glob("*.pdf"))