Fix/issue 87 #89

Merged

lars merged 2 commits from fix/issue-87 into master 2026-08-28 11:45:01 +02:00

Conversation 0 Commits 2 Files Changed 8

+383 -7

lars commented 2026-08-28 11:32:28 +02:00

Owner

Copy Link

Copy Source

No description provided.

lars added 2 commits 2026-08-28 11:32:29 +02:00

Add inference-time model_config overrides with a sampling-key allowlist (gitea #87) ... bd255419e1

giant predict/rollout rebuilt models straight from ckpt["model_config"] with
no way to change sampling-only keys (e.g. stage2_model.n_sec.stop_sampling)
without retraining. Adds config_overrides to load_for_inference, validated
against giant.config.INFERENCE_OVERRIDES so a typo or shape-bearing key
raises CheckpointCompatibilityError up front instead of an opaque
load_state_dict mismatch. Wired as a repeatable --set dotted.path=value on
both CLI commands, recorded in the rollout YAML sidecar, and surfaced in
`giant model summary`'s output.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/master' into fix/issue-87 ... 1ec333ff6d

# Conflicts:
#	giant/config.py

lars merged commit 5c93457081 into master 2026-08-28 11:45:01 +02:00

lars deleted branch fix/issue-87 2026-08-28 11:45:02 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

architecture

bug

Silent/wrong behavior, no crash

experiment

feature

New feature matching the v0.3 redesign

investigation

modularity

Making the network genuinely pluggable

performance

phase2

validation

wontfix

Not being fixed right now

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

lars (Lars Bogner)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lars/giant#89