Add "none" variants for every plug point (router, history, trunk) #45

New Issue

2026-08-13T15:08:04+02:00

lars commented

2026-08-13 15:08:04 +02:00

Once the trunk registry and pluggable history-encoder issues (#33, #35) land:
router.type = "none", history = "none", trunk.type = "linear". Each is a
few lines, and together they turn "is this component earning its parameters?"
from a code change into a config sweep — which giant/tools/hparam_scan.py
can already drive.

Migrated from issues.md (v0.3.0 branch review, 2026-08-13), Issue 20.

Once the trunk registry and pluggable history-encoder issues (#33, #35) land: `router.type = "none"`, `history = "none"`, `trunk.type = "linear"`. Each is a few lines, and together they turn "is this component earning its parameters?" from a code change into a config sweep — which `giant/tools/hparam_scan.py` can already drive. --- Migrated from `issues.md` (v0.3.0 branch review, 2026-08-13), Issue 20.

lars added the modularity feature labels 2026-08-13 15:08:04 +02:00

lars added a new dependency 2026-08-13 15:23:29 +02:00

#33 Trunk architecture is not selectable (hardcoded ResMLP/MoE choice)

lars added a new dependency 2026-08-13 15:23:30 +02:00

#35 HistoryEncoder interface is incomplete, so callers isinstance-check AttentionHistory

Sign in to join this conversation.