From 26aa9d3fde9862b5b194bf9f8caf7d0490066c1b Mon Sep 17 00:00:00 2001 From: Lars Bogner Date: Thu, 30 Jul 2026 10:29:19 +0200 Subject: [PATCH] Pass --seed through to the train/val event split MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit make_event_split() defaults to seed=42, and run_train_job was calling it without forwarding t["seed"] — so the configured --seed affected model init/EMA/etc. but not which events landed in train vs. val, which silently always used seed 42 regardless of --seed. Co-Authored-By: Claude Sonnet 5 --- giant/pipeline.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/giant/pipeline.py b/giant/pipeline.py index f24fcd4..b265dbe 100644 --- a/giant/pipeline.py +++ b/giant/pipeline.py @@ -70,7 +70,7 @@ def run_train_job( cache.event_index = (unique_ids, counts) train_events, val_events = make_event_split( - unique_ids, val_fraction=t["val_fraction"] + unique_ids, val_fraction=t["val_fraction"], seed=t["seed"] ) events_arr = np.array(sorted(train_events)) n_train_steps = setup_cache.n_train_steps_for_split(unique_ids, counts, events_arr)