Fix ruff, ty, and pytest failures; apply ruff format

Removes unused imports and an ambiguous variable name, narrows
Optional types before use so ty's flow analysis is satisfied, swaps
sum() over polars expressions for pl.sum_horizontal to avoid the
Literal[0] fallback type, and converts numpy bin edges to plain lists
before passing to matplotlib's hist (whose stub only accepts
Sequence[float]). Also applies ruff format across the repo, which had
drifted out of sync with the formatter.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

scripts/create_root_files.py

@@ -61,7 +61,9 @@ def parse_detector_spec(spec: str) -> tuple[str, str | None]:
     if ":" in spec:
         label, config = spec.split(":", 1)
         if not label or not config:
-            raise PlanError(f"invalid --detector spec {spec!r}: expected NAME or NAME:CONFIG")
+            raise PlanError(
+                f"invalid --detector spec {spec!r}: expected NAME or NAME:CONFIG"
+            )
         return label, config
     return spec, None
 
@@ -111,7 +113,10 @@ def run_job(
     gen: str,
     tmp_root: Path,
 ) -> JobResult:
-    workdir = tmp_root / f"{kind}-{gen}-{job.detector}-{job.shard_index:03d}-{uuid.uuid4().hex[:8]}"
+    workdir = (
+        tmp_root
+        / f"{kind}-{gen}-{job.detector}-{job.shard_index:03d}-{uuid.uuid4().hex[:8]}"
+    )
     workdir.mkdir(parents=True)
 
     cmd = [str(executable)]
@@ -123,25 +128,42 @@ def run_job(
 
     if result.returncode != 0:
         return JobResult(
-            job, False, None,
+            job,
+            False,
+            None,
             f"executable exited {result.returncode}",
-            result.stdout, result.stderr,
+            result.stdout,
+            result.stderr,
         )
 
     produced = sorted(workdir.glob("*.root"))
     if len(produced) != 1:
         return JobResult(
-            job, False, None,
+            job,
+            False,
+            None,
             f"expected exactly one .root output in {workdir}, found {len(produced)}: "
             f"{[p.name for p in produced]}",
-            result.stdout, result.stderr,
+            result.stdout,
+            result.stderr,
         )
 
-    dest = dataset_root / "raw" / kind / gen / job.detector / f"shard-{job.shard_index:03d}.root"
+    dest = (
+        dataset_root
+        / "raw"
+        / kind
+        / gen
+        / job.detector
+        / f"shard-{job.shard_index:03d}.root"
+    )
     if dest.exists():
         return JobResult(
-            job, False, None, f"refusing to overwrite existing {dest}",
-            result.stdout, result.stderr,
+            job,
+            False,
+            None,
+            f"refusing to overwrite existing {dest}",
+            result.stdout,
+            result.stderr,
         )
 
     dest.parent.mkdir(parents=True, exist_ok=True)
@@ -166,7 +188,14 @@ def run_all(
     with ThreadPoolExecutor(max_workers=max_workers) as pool:
         futures = {
             pool.submit(
-                run_job, job, executable, events_per_file, dataset_root, kind, gen, tmp_root
+                run_job,
+                job,
+                executable,
+                events_per_file,
+                dataset_root,
+                kind,
+                gen,
+                tmp_root,
             ): job
             for job in jobs
         }
@@ -212,8 +241,19 @@ def run_make_root(
     print(f"=== {'EXECUTING' if execute else 'DRY RUN'} ===")
     print(f"executable: {executable}")
     for job in planned_jobs:
-        cmd = [str(executable)] + ([job.config] if job.config else []) + [str(events_per_file)]
-        dest = dataset_root_path / "raw" / kind / gen / job.detector / f"shard-{job.shard_index:03d}.root"
+        cmd = (
+            [str(executable)]
+            + ([job.config] if job.config else [])
+            + [str(events_per_file)]
+        )
+        dest = (
+            dataset_root_path
+            / "raw"
+            / kind
+            / gen
+            / job.detector
+            / f"shard-{job.shard_index:03d}.root"
+        )
         print(f"  {' '.join(cmd)}  ->  {dest}")
 
     if not execute:
@@ -223,8 +263,14 @@ def run_make_root(
     tmp_root = dataset_root_path / ".sim-tmp"
     tmp_root.mkdir(parents=True, exist_ok=True)
     results = run_all(
-        planned_jobs, executable, events_per_file, dataset_root_path, kind, gen,
-        max_workers=jobs, tmp_root=tmp_root,
+        planned_jobs,
+        executable,
+        events_per_file,
+        dataset_root_path,
+        kind,
+        gen,
+        max_workers=jobs,
+        tmp_root=tmp_root,
     )
     if tmp_root.is_dir() and not any(tmp_root.iterdir()):
         tmp_root.rmdir()
@@ -233,7 +279,10 @@ def run_make_root(
     if failures:
         print(f"\n{len(failures)} of {len(results)} job(s) failed:", file=sys.stderr)
         for r in failures:
-            print(f"  {r.job.detector} shard-{r.job.shard_index:03d}: {r.message}", file=sys.stderr)
+            print(
+                f"  {r.job.detector} shard-{r.job.shard_index:03d}: {r.message}",
+                file=sys.stderr,
+            )
         raise SystemExit(1)
 
     print(f"\nAll {len(results)} job(s) completed.")