Fix routing and add tests #1

2026-06-19T14:34:51+02:00

lars commented

2026-06-19 14:34:51 +02:00

No description provided.

lars added 4 commits 2026-06-19 14:34:51 +02:00

Fix route optimizer and group assignment; add test suite 07f8415eb1

Route building / optimization (tatami_masterplan.py):
- fast_total_time was permutation-invariant: it applied get_courses to
  group *values* instead of slots and ignored the permutation, so every
  ordering scored identically and the annealing optimized nothing. It now
  maps each rotation slot to its assigned group via the permutation.
- Replaced the broken next_permutation/simulated_annealing (enumerated n!
  orderings per iteration, fed unnormalized Boltzmann weights to
  np.random.choice -> ValueError, and returned the last random sample) with
  a standard neighbor-swap annealer that tracks and returns the best
  solution and handles <2 slots.
- Convert the reduced Timedelta matrix to float seconds before annealing
  (np.exp can't operate on Timedelta).

Group building (tatami_masterplan.py):
- assign_courses set each group's hosts (sorted by course) before all
  courses were assigned, so hosts whose course was still None got
  mis-ordered. Assign all courses first, then wire up hosts.
- get_masterplan no longer mutates the caller's participant list.

classes.py:
- Narrow casts on distance-matrix lookups to satisfy the mypy gate
  (pre-existing failures).

Tests:
- Add pytest suite (74 tests) covering the rotation topology, route cost
  and optimization, the domain model, the masterplan pipeline, and the
  Routes API wrapper (HTTP mocked). The cost cross-check caught the
  assign_courses ordering bug above.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Load Google Maps API key from a .env file 202b8e5813

- Add python-dotenv and call load_dotenv() in traveltimes.py before reading
  GOOGLE_MAPS_API_KEY (exported env vars still take precedence).
- Add .env.example template; the real .env stays gitignored.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Add opt-in live API end-to-end test 52c4d42212

- test_e2e_api.py: minimal 2-address (4-element) call to the real Google
  Routes API; reads the real key from env/.env and skips on a placeholder.
- Marked `e2e` and deselected by default via addopts; run with
  `pytest -m e2e`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Add extensive README 899fb76b45

Document the running-dinner concept, setup (uv + .env API key), CSV input
schema, how to run it (CLI and library), output format, a "what to tweak"
table mapping each knob to its file:line, the algorithm (group building,
rotation topology, annealing), testing (offline + opt-in e2e), limitations,
and development commands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

lars merged commit 6cfbe964e9 into main

2026-06-19 14:35:02 +02:00

lars referenced this issue from a commit

2026-07-24 08:21:47 +02:00

Merge pull request 'Fix routing and add tests' (#1) from fix-routing-and-add-tests into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lars/Tatami#1